Remove photutils from Astroquery astrometry.net #3067
Conversation
… kwarg to decorator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
=======================================
Coverage 67.54% 67.55%
=======================================
Files 233 233
Lines 18320 18327 +7
=======================================
+ Hits 12375 12380 +5
- Misses 5945 5947 +2 ☔ View full report in Codecov by Sentry. |
astroquery/astrometry_net/core.py
Outdated
| @@ -412,6 +415,11 @@ def solve_from_image(self, image_file_path, *, force_image_upload=False, | |||
| cache=False, | |||
| files={'file': f}) | |||
| else: | |||
| warning_msg = "Removing photutils functionality to obtain extracted positions list from " \ | |||
| "AstoromertyNetClass.solve_from_source_list. Users will need to " \ | |||
There was a problem hiding this comment.
| "AstoromertyNetClass.solve_from_source_list. Users will need to " \ | |
| "AstrometryNetClass.solve_from_source_list. Users will need to " \ |
There was a problem hiding this comment.
Hey @keflavich thank you for the feedback. I fixed the typo in 4e23354
|
@mfixstsci - Tip of the day, use these words to cross-link the issue and thus autoclose. Unfortunately 'address' is not part of the list: |
Thank you this is really useful! |
astroquery/astrometry_net/core.py
Outdated
| warning_msg = "Removing photutils functionality to obtain extracted positions list from " \ | ||
| "AstrometryNetClass.solve_from_source_list. Users will need to " \ | ||
| "submit pre-extracted catalog positions or a fits file for https://nova.astrometry.net/ " \ | ||
| "to extract with their algorithm." |
There was a problem hiding this comment.
Nitpick, but I would rephrase this a bit, as it's the user who sees this message not a third party.
| warning_msg = "Removing photutils functionality to obtain extracted positions list from " \ | |
| "AstrometryNetClass.solve_from_source_list. Users will need to " \ | |
| "submit pre-extracted catalog positions or a fits file for https://nova.astrometry.net/ " \ | |
| "to extract with their algorithm." | |
| warning_msg = ("Running photutils functionality within astroquery to obtain extracted positions list from " | |
| "AstrometryNetClass.solve_from_source_list() is deprecated and will be removed in the next release. " | |
| "You need to submit catalog positions or a fits file to obtain an astrometric solution using this service.") |
|
Hello @mfixstsci! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-07-14 17:22:20 UTC |
This PR addresses #2782.
Currently
astroquery/astrometry_net/core.pytries to importphotutils.detection.DAOStarFinderandastropy.nddata.CCDDataand will make decisions on how sources in the fits file passed toAstrometryNetClassare extracted. The following additions will prepare the photutils portion of the algorithm for removal with the goal that if a source catalog is not provided, thatnova.astrometry.netwill perform the source extraction.photutils.nova.astrometry.netto extract sources.Fixes: #2782.